From dd7da4533b7cafb4996b2fe94e74b993a92651d7 Mon Sep 17 00:00:00 2001 From: djairoh Date: Fri, 12 May 2023 14:31:06 +0200 Subject: [PATCH] changed 2 functions to be slightly more efficient (u8 instead of i32) --- src/structs/config.rs | 6 +----- src/update_players.rs | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/structs/config.rs b/src/structs/config.rs index 4f387b0..b5a071e 100644 --- a/src/structs/config.rs +++ b/src/structs/config.rs @@ -158,11 +158,7 @@ impl Config { /// If the given identity is not in the map, the value of i32::MAX is returned instead. /// /// TODO: using a HashMap would be more efficient i think. - pub fn find_player_priorities_idx(&self, name: &str) -> i32 { - match self.player_priorities.iter() - .position(|x| x.eq(&name)) { - Some(idx) => idx as i32, - None => i32::MAX, + pub fn find_player_priorities_idx(&self, name: &str) -> u8 { } } diff --git a/src/update_players.rs b/src/update_players.rs index fde6c5a..2d3a2c5 100644 --- a/src/update_players.rs +++ b/src/update_players.rs @@ -38,7 +38,7 @@ pub fn update_players(pf: &PlayerFinder, cfg: &Config, mut data: &mut Data) { if players.is_empty() { data.current_player = None; } else { - let mut active: BTreeMap = BTreeMap::new(); + let mut active: BTreeMap = BTreeMap::new(); for player in players { if let Ok(mpris::PlaybackStatus::Playing) = player.get_playback_status() { let idx = cfg.find_player_priorities_idx(player.identity());